ISSUE: 1585 | Add --wait flag to databases resize command

[Yordaniss]

ISSUE #1585

• added bool flag into resize command
• added wait functionality into resize
• adjusted test

[andrewsomething]

Hi @Yordaniss. Thank you so much for the pull request!

I've left a few comments in-line with suggestions. In addition to that, it would be great to add a new test case to the TestDatabaseResize test.

doctl/commands/databases_test.go

Line 618 in 6804c7d

func TestDatabaseResize(t *testing.T) {

Something along the line of:

	// Success with wait flag
	withTestClient(t, func(config *CmdConfig, tm *tcMocks) {
		tm.databases.EXPECT().Resize(testDBCluster.ID, r).Return(nil)
		tm.databases.EXPECT().Get(testDBCluster.ID).Return(&testDBCluster, nil)
		config.Args = append(config.Args, testDBCluster.ID)
		config.Doit.Set(config.NS, doctl.ArgSizeSlug, testDBCluster.SizeSlug)
		config.Doit.Set(config.NS, doctl.ArgDatabaseNumNodes, testDBCluster.NumNodes)
		config.Doit.Set(config.NS, doctl.ArgDatabaseStorageSizeMib, testDBCluster.StorageSizeMib)
		config.Doit.Set(config.NS, doctl.ArgCommandWait, true)

		err := RunDatabaseResize(config)
		assert.NoError(t, err)
	})

Comparing that to the existing tests, you'll see it passes the wait flag and tests that the Get method is called by waitForDatabaseReady when the flag is passed.

Let us know if you have any questions!

[Yordaniss]

Hi @andrewsomething thanks a lot for a feedback. I simplified logic and added test case. 🙂

[andrewsomething]

👍 Great work! Thanks again for the contribution!