Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ntate/appdev/rebased #1237

Merged
merged 46 commits into from
Sep 22, 2022
Merged

Ntate/appdev/rebased #1237

merged 46 commits into from
Sep 22, 2022

Conversation

nicktate
Copy link
Contributor

@nicktate nicktate commented Sep 20, 2022 •
edited
Loading

Descriptions

What does this pull request accomplish

  • Adds in the doctl app dev command subtree
  • Adds command/charm package with foundational constructs to enable interactivity throughout commands

Additional Notes

This PR is ready to review for merge-ability into main with the following caveats:

The change set is massive 😅 but a large majority is related to vendor changes; this code went through an initial set of reviews to feature/appdev

@nicktate nicktate force-pushed the ntate/appdev/rebased branch 3 times, most recently from dbe0f8c to 568efdc Compare September 20, 2022 16:07
@nicktate
Copy link
Contributor Author

Error: commands/displayers/reserved_ip.go:58:19: f.ProjectID undefined (type do.ReservedIP has no field or method ProjectID)

The current test failure is due to the godo replacement; it will be resolved once we have updated this PR w/ the relevant godo release

@nicktate nicktate force-pushed the ntate/appdev/rebased branch 2 times, most recently from 6506581 to a0c801e Compare September 20, 2022 18:27
nicktate and others added 23 commits September 21, 2022 13:19
@nicktate @kamaln7
Feature/appdev (digitalocean#1204)
0186fc0 
* apps: add base scaffolding for app dev command subtree

* charm templates: change up method signatures for easier use

* only use 1.18.x in ci

* add internal package to unit test

* disable interactive mode

* only use logging pager in interactive mode

Co-authored-by: Kamal Nasser <kamal@digitalocean.com>
@kamaln7 @nicktate
extract pager component and improve build log output
c02753a
@nicktate
Add support for an app dev config and management (digitalocean#1208)
20f2690
@nicktate
Add support for build environment variables (digitalocean#1209)
2b6a69d
@kamaln7 @nicktate
confirmation prompt component
36d8326
@kamaln7 @nicktate
text input component
31b3e38
@nicktate
Add support for build command overrides (digitalocean#1211)
5455c01
@nicktate
Add copy on write support for CNB builds (digitalocean#1213)
76ed5b1
@kamaln7 @nicktate
confirm: display result options
593fb87
@kamaln7 @nicktate
split off list subpackage
a0085e3
@kamaln7 @nicktate
split off pager subpackage
aecf6b4
@kamaln7 @nicktate
split off template and textbox packages
38f276c
@kamaln7 @nicktate
StyledText for icons
9a3e937
@kamaln7 @nicktate
split off text component
4b8f9e4
@kamaln7 @nicktate
improve indent util
b01e229
@kamaln7 @nicktate
confirm: clarify prompt persistance behavior
6264528
@nicktate
Add snap support for docker interface for app dev builds (digitalocea…
3b65be1 
…n#1214)

* Add snap support for docker interface for app dev builds

* add snap warning message
@kamaln7 @nicktate
support cnb versioning, clean up build envs (digitalocean#1215)
243e763
@nicktate
add support for local cnb caching (digitalocean#1216)
9a16b07 
* add support for local cnb caching

* address pr feedback
@kamaln7 @nicktate
charm: improved output handling, add warning textbox variant
f7f6fa2
@kamaln7 @nicktate
add config interfaces and types
91c0f2b
@kamaln7 @nicktate
use new config interfaces, add support for per-component config
719f276
@kamaln7 @nicktate
address pr feedback, app dev workspace
e3aa002
kamaln7 and others added 21 commits September 21, 2022 13:19
@kamaln7 @nicktate
structured config
0a9597d
@kamaln7 @nicktate
unexport Config.AppID and config.AppSpecPath
92d52ab
@kamaln7 @nicktate
unexport internal method
0f015ea
@kamaln7 @nicktate
fix unclosed file handler in tests
0b2136d
@kamaln7 @nicktate
test setting and unsetting component-level settings
339e4c4
@kamaln7 @nicktate
appdev: handle user cancellation, log pager styling updates (digitalo…
262e3d6 
…cean#1229)

* correctly handle user cancellation

* log pager: update header/footer styling, scroll indicator

* log pager: add title spinner
@nicktate
add support to build static site server image
e89df1b
@nicktate
add docker support for static builds
606710d
@kamaln7 @nicktate
docker static site build cleanup
3b93927
@kamaln7 @nicktate
docker static site build tests
34232ab
@kamaln7 @nicktate
cnb static site build cleanup
2abc7e6
@kamaln7 @nicktate
cnb static site build tests
2597826
@kamaln7 @nicktate
docker static site build input validation updates
f2d408f 
remove /var/run/docker.sock dependency from tests
@kamaln7 @nicktate
fix path handling on windows
5aee488
@kamaln7 @nicktate
intercept ctrl-c to exit cleanly
0db8802
@nicktate
Ntate/appdev/macossupport (digitalocean#1235)
258f314 
* mount docker.sock.raw for mac docker-for-desktop

* update local builder to v0.50.2
@nicktate
support for windows docker-for-desktop (digitalocean#1238)
d1ee9a0
@kamaln7 @nicktate
appdev: pull required container images (digitalocean#1240)
07ba9dd 
* pull required container images

* pull cnb stack run image

* update no app spec error message
@kamaln7 @nicktate
vendor latest godo
643ecf2
@nicktate
bump godo to v1.85.0
4e6be30
@nicktate
support new godo interface types
e8dfe8f
@nicktate nicktate force-pushed the ntate/appdev/rebased branch from 94194a2 to e8dfe8f Compare September 21, 2022 20:43
andrewsomething
andrewsomething reviewed Sep 22, 2022
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all this looks great. I've given it a pretty thorough review, but admittedly need to rely on you all for some of the finer details of the build process. A few comments inline, but they are all pretty minor.

commands/apps_dev.go Outdated Show resolved Hide resolved
commands/apps_dev_config.go Outdated Show resolved Hide resolved
commands/apps_dev.go Show resolved Hide resolved
internal/apps/builder/builder.go Show resolved Hide resolved
commands/apps_dev.go Show resolved Hide resolved
commands/apps_dev_config.go Outdated Show resolved Hide resolved
@andrewsomething andrewsomething self-requested a review September 22, 2022 18:19
andrewsomething
andrewsomething approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andrewsomething andrewsomething merged commit de1918a into digitalocean:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamaln7 kamaln7 kamaln7 left review comments

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicktate @andrewsomething @kamaln7