Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands/auth: stop printing the token to stdout #1332

Merged
merged 1 commit into from
Dec 22, 2022
Merged

commands/auth: stop printing the token to stdout #1332

merged 1 commit into from
Dec 22, 2022

Conversation

freddierice
Copy link
Contributor

Token shouldn't be output in cleartext.

danaelhe
danaelhe approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@danaelhe danaelhe merged commit 567fc74 into digitalocean:main Dec 22, 2022
@freddierice freddierice deleted the remove-print-token branch December 22, 2022 19:46
danaelhe added a commit that referenced this pull request Dec 22, 2022
@danaelhe
Revert "commands/auth: stop printing the token to stdout (#1332)"
a842bb4 
This reverts commit 567fc74.
@danaelhe danaelhe mentioned this pull request Dec 22, 2022
Merged
danaelhe added a commit that referenced this pull request Dec 22, 2022
@danaelhe
Revert "commands/auth: stop printing the token to stdout (#1332)" (#1333
111ec1e 
)

This reverts commit 567fc74.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danaelhe danaelhe danaelhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freddierice @danaelhe