Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app spec validate-offline (Resolves #1449) #1450

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Add app spec validate-offline (Resolves #1449) #1450

merged 5 commits into from
Oct 24, 2023

Commits on Oct 22, 2023

  1. integration/apps_spec_test: Add tests for apps spec validate-offline

    @trinitronx
    trinitronx committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    ae6c1b6 View commit details
    Browse the repository at this point in the history

  2. commands/apps: Add apps spec validate-offline command (Fixes digitalo… 

    …cean#1449)

Implement a new command to validate an app spec without requiring
auth & connection to the API. This is useful for validating app specs
in CI pipelines and untrusted environments.  As there is no currently
published [YAML schema][1] for use with [`redhat.vscode-yaml`][2], this
seems to be the best approach for now.

[1]: https://www.schemastore.org/json/
[2]: https://github.com/redhat-developer/yaml-language-server
    @trinitronx
    trinitronx committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    385ae5f View commit details
    Browse the repository at this point in the history

  3. commands/apps: Refactor spec validation into a common function

    @trinitronx
    trinitronx committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    6204426 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. commands/apps: refactor validate-offline -> --schema-only (Fixes digi… 

    …talocean#1449) (#1)

Thanks to @andrewsomething for the suggestion!

Reference:

- digitalocean#1450 (review)
    @trinitronx
    trinitronx committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    8319fec View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Add integration test without auth.

    @andrewsomething
    andrewsomething committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c54c617 View commit details
    Browse the repository at this point in the history