ci: Configure crate-ci/typos and auto fix what I can #1551
Conversation
| // ArgDatabaseTopicMesssageDownConversionEnable determines whether brokers should convert messages for consumers expecting older message formats | ||
| ArgDatabaseTopicMesssageDownConversionEnable = "message-down-conversion-enable" | ||
| // ArgDatabaseTopicMessageDownConversionEnable determines whether brokers should convert messages for consumers expecting older message formats | ||
| ArgDatabaseTopicMessageDownConversionEnable = "message-down-conversion-enable" |
There was a problem hiding this comment.
As this is a "code aware" spell checker, any chance you happen to know if there is a way to exclude existing exported vars/consts? That's not really an issue for doctl itself, but if we were to bring this into say godo, we'd want to avoid breaking changes.
There was a problem hiding this comment.
so best i've found in the past was default.extend-identifiers in the config, but nothing automated
I believe typos also has a cli flag for listing all the identifiers it finds
that being said, fixing the spelling is an easy breaking change to handle for end users, its not like they have to figure out how to rewrite code because a function no longer exists.
|
I can when I get a minute. Do you want a PR github action too? |
If you're up for it. That would be great. We can add that latter too to no block this PR. |
decided to do it seperately |
Can setup a github action too
https://github.com/crate-ci/typos/blob/master/docs/github-action.md