Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DBAAS] | Add API endpoint for applying cluster patches #1579

Merged
merged 10 commits into from
Sep 17, 2024
Merged

[DBAAS] | Add API endpoint for applying cluster patches #1579

merged 10 commits into from
Sep 17, 2024

Conversation

vsharma6855
Copy link
Contributor

@vsharma6855 vsharma6855 commented Sep 11, 2024 •
edited
Loading

Add 'doctl databases install_update <database_uuid>' command and unit tests.

@vsharma6855 vsharma6855 marked this pull request as draft September 11, 2024 13:52
@vsharma6855 vsharma6855 marked this pull request as ready for review September 11, 2024 14:59
@loosla
Copy link
Contributor

loosla commented Sep 12, 2024

Thanks for your contribution 🚀

I believe we are using hyphen instead of underscores (install_update) in commands names.
Maybe just update can be clear enough as a name?
I'd rely on @andrewsomething as he may share more thoughts about the naming.

andrewsomething
andrewsomething requested changes Sep 12, 2024
View reviewed changes
commands/databases.go Outdated Show resolved Hide resolved
@loosla
Copy link
Contributor

loosla commented Sep 17, 2024

Looks good to me 👍

andrewsomething
andrewsomething approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@andrewsomething andrewsomething merged commit 6e273a4 into digitalocean:main Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsharma6855 @loosla @andrewsomething