Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[databases]: add support for Opensearch advanced configuration #1588

Merged
merged 2 commits into from
Oct 3, 2024
Merged

[databases]: add support for Opensearch advanced configuration #1588

merged 2 commits into from
Oct 3, 2024

Conversation

loosla
Copy link
Contributor

@loosla loosla commented Sep 30, 2024

This PR is adding a support for Opensearch advanced configuration: Get, Update.

Command examples to test

doctl databases configuration get <db-cluster-id> -e opensearch

doctl databases configuration update <db-cluster-id> -e opensearch --config-json '{"ism_history_max_age_hours":10}'

@loosla loosla marked this pull request as ready for review October 2, 2024 15:31
@loosla
Copy link
Contributor Author

loosla commented Oct 2, 2024

Could you please tell me how output for ReindexRemoteWhitelist should look like
ReindexRemoteWhitelist alush.org:80, cloud.digitalocean.com:8080
or
ReindexRemoteWhitelist [alush.org:80 cloud.digitalocean.com:8080] ?

Now it's ReindexRemoteWhitelist [alush.org:80 cloud.digitalocean.com:8080] .
Please let me know if it should look differently 🙏

andrewsomething
andrewsomething approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@loosla loosla merged commit 6804c7d into main Oct 3, 2024
8 checks passed
@loosla loosla deleted the alushnikova/add-opensearch-advanced-conf branch October 3, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

@bentranter bentranter Awaiting requested review from bentranter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loosla @andrewsomething