Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves tag handling for droplet create #160

Merged
merged 1 commit into from
Nov 14, 2016

Conversation

akshaychhajed
Copy link
Contributor

Fixes #127
Runs check to ensure tags exist before creating droplet

@xmudrii
Copy link
Contributor

xmudrii commented Oct 29, 2016

Looks good.

But what about creating tag alongside Droplet? That can be done automatically, when you try to create Droplet with new tag, create tag too. Or ask user to create tag/ignore/cancel creation.
I personally I would go automatically, as I think less interaction == better, especially because doctl is made for scripts integration and so on.
Probably @bryanl can give us his opinion on this topic. 👍

@mchitten
Copy link
Contributor

This looks fine. Today we implemented tags in droplet create, which does essentially what @xmudrii is suggesting (creating a tag and applying it to the droplet during create). That is implemented in #165.

For this, 👍 .

@nanzhong
Copy link
Contributor

lgtm 👍

@nanzhong nanzhong merged commit f78ff56 into digitalocean:master Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants