Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing positional resource id descriptions #1600

Conversation

zikalino
Copy link
Contributor

@zikalino zikalino commented Oct 25, 2024

I have fixed some other places and replaced with in command descriptions as it's more common and descriptive pattern.

@zikalino zikalino force-pushed the zikalino-fixing-command-descriptions branch from 1111d03 to c527307 Compare October 25, 2024 14:29
@zikalino zikalino marked this pull request as ready for review October 25, 2024 14:31
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another great contribution! I left a couple comments inline regarding the container registry commands. They do not actually require a positional argument.

commands/registry.go Outdated Show resolved Hide resolved
commands/registry.go Outdated Show resolved Hide resolved
@zikalino zikalino force-pushed the zikalino-fixing-command-descriptions branch 2 times, most recently from 3ebcbab to ab498e6 Compare October 25, 2024 14:47
@zikalino
Copy link
Contributor Author

ok, removed registry changes. i left other improvements - probably still worth merging.

@zikalino zikalino force-pushed the zikalino-fixing-command-descriptions branch from ab498e6 to 65379d9 Compare October 25, 2024 14:50
@andrewsomething
Copy link
Member

Definetly! Thanks again!

@andrewsomething andrewsomething merged commit 568c181 into digitalocean:main Oct 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants