-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support for droplet autoscaler #1606
Conversation
cc @andrewsomething when you have a chance 🙏 |
bba410c
to
805b1f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great. There are some minor copy suggestions inline.
The one issue I'm seeing is with the Displayable
implementation. Rather than using a single type with switch statements, each should be its own type. This will allow you to remove the format flags that have been added manually. When the displayer is implemented correctly, the flag is added automatically. The help output will also have the column names populated automatically.
It would also be great to get some additional help information into the command long descriptions, but that can follow later. If there is someone on the product docs team working on this release, they might be able help there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! This is very close. Though I did notice that you changed the commands that require an autoscale pool ID from using a positional argument to an --id
flag. Any particular reason for that?
Most doctl
commands that act on an existing resource tag the ID as a positional argument. For example: doctl compute droplet get <id>
Unless there is a specific reason not too, it would be more consistent to do so here too.
@andrewsomething Yeah should've perhaps checked in with you on this: it just seemed counter-intuitive that we accept
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
Droplet autoscaler is currently in closed alpha and enabled for select customer.
Nit change also includes marking the new load balancer feature flags as visible in the cli text (now that these features are available since GA).
TODO: