Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-9859 Add doctl apps console command to start a console session to a component #1612

Merged
merged 23 commits into from
Nov 18, 2024

Conversation

blesswinsamuel
Copy link
Contributor

@blesswinsamuel blesswinsamuel commented Nov 13, 2024

This PR adds a doctl apps console command to start a console session to a component.

To try this out:

go build -o /tmp/doctl cmd/doctl/main.go
/tmp/doctl apps console <app-id> <component-name>

Note: The tests for this PR will pass only after digitalocean/godo#754 is released and go.mod updated here.

@blesswinsamuel blesswinsamuel changed the title Add doctl apps console command to start a console session to a component APPS-9765 Add doctl apps console command to start a console session to a component Nov 13, 2024
@blesswinsamuel blesswinsamuel changed the title APPS-9765 Add doctl apps console command to start a console session to a component APPS-9859 Add doctl apps console command to start a console session to a component Nov 13, 2024
commands/apps.go Outdated Show resolved Hide resolved
pkg/listen/listen.go Outdated Show resolved Hide resolved
@blesswinsamuel blesswinsamuel marked this pull request as ready for review November 13, 2024 16:56
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Let's sort out the question about the stdin/resize functions, and we'll be good to go.

pkg/listen/listen.go Outdated Show resolved Hide resolved
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@andrewsomething andrewsomething merged commit bd65bcc into digitalocean:main Nov 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants