-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APPS-9859 Add doctl apps console command to start a console session to a component #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blesswinsamuel
changed the title
Add doctl apps console command to start a console session to a component
APPS-9765 Add doctl apps console command to start a console session to a component
Nov 13, 2024
blesswinsamuel
changed the title
APPS-9765 Add doctl apps console command to start a console session to a component
APPS-9859 Add doctl apps console command to start a console session to a component
Nov 13, 2024
blesswinsamuel
commented
Nov 13, 2024
blesswinsamuel
commented
Nov 13, 2024
blesswinsamuel
force-pushed
the
exec
branch
2 times, most recently
from
November 13, 2024 16:53
0cf339d
to
8c84cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Let's sort out the question about the stdin/resize functions, and we'll be good to go.
This also removes the "Press any key to exit." prompt, which I felt was annoying.
andrewsomething
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
doctl apps console
command to start a console session to a component.To try this out:
Note: The tests for this PR will pass only after digitalocean/godo#754 is released and go.mod updated here.