Added new actions for Volume and Volume-Action #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aybabtme
approved these changes
Dec 23, 2016
| @@ -7,12 +7,13 @@ type Volume struct { | |||
| *godo.Volume | |||
| } | |||
|
|
|||
| // VolumesService is an interface for interacting with DigitalOcean's account api. | |||
| // VolumesService is an interface for interacting with DigitalOcean's volume api. | |||
|
lgtm but will need a rebase and small change now that #171 is merged right? |
xmudrii
force-pushed
the
volume-extended
branch
from
6b0726c
to
4040189
Compare
|
@nanzhong is it good now? :) |
fixed imports added copyright headers vendoring godo update changes for digitalocean#171
xmudrii
force-pushed
the
volume-extended
branch
from
3ffd041
to
2efda6a
Compare
nanzhong
reviewed
Dec 23, 2016
| @@ -134,4 +134,6 @@ const ( | |||
|
|
|||
| // ArgResourceType is the resource type for snapshot. | |||
| ArgResourceType = "resource" | |||
| // ArgSnapshotDesc is the description for volume snapshot. | |||
| ArgSnapshotDesc = "snapshot-desc" | |||
There was a problem hiding this comment.
Sorry tiny nitpick I just noticed, could we move this up to under ArgSnapshotName to make it a little easier to find? https://github.com/digitalocean/doctl/pull/173/files#diff-07ee57a49d1c0b692bd79676cc31dd6fR54
I'll merge this PR after that.
There was a problem hiding this comment.
Not a problem, thanks for noting. Moved both up. 👍
nanzhong
approved these changes
Dec 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave it a try, I hope it's OK 👍 =)
cc @aybabtme