Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix make docker_build #513

Merged
merged 1 commit into from
Jul 23, 2019
Merged

fix make docker_build #513

merged 1 commit into from
Jul 23, 2019

Conversation

hilary
Copy link
Contributor

@hilary hilary commented Jul 23, 2019

The whole make docker_build infrastructure had several issues,
but it is working now :/

fix make docker_build
2e0b780 
The whole `make docker_build` infrastructure had several issues,
but it is working now :/
@hilary hilary requested a review from bentranter July 23, 2019 19:16
bentranter
bentranter approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As a side note, looking at the Dockerfile.build reminds me we should bump the base image up to the latest Go release at some point (I think latest is golang:1.12.7-alpine). I can do that in a separate PR if you'd prefer.

@hilary hilary merged commit 13c1a44 into digitalocean:master Jul 23, 2019
@hilary hilary deleted the add_build_linux_amd64 branch July 23, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentranter bentranter bentranter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hilary @bentranter