Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump and tag #515

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Bump and tag #515

merged 3 commits into from
Jul 24, 2019

Conversation

hilary
Copy link
Contributor

@hilary hilary commented Jul 23, 2019

No description provided.

Hilary Holz added 2 commits July 23, 2019 14:32
improve version.sh
d379aef 
allow for detached HEAD
remove pipefail, as it causes false positives
add '-s' option
add make version
6be1632
@hilary hilary requested a review from bentranter July 23, 2019 22:40
@hilary hilary changed the title Bump version Bump and tag Jul 23, 2019
bentranter
bentranter reviewed Jul 24, 2019
View reviewed changes
scripts/bumpversion.sh Outdated Show resolved Hide resolved
bentranter
bentranter approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks & works great! One question about a commented out line, other than that LGTM.

add make bump-and-tag
8dd417c 
pull out of release script
@hilary hilary merged commit 749efc7 into digitalocean:master Jul 24, 2019
@hilary hilary deleted the bump-version branch July 24, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentranter bentranter bentranter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hilary @bentranter