WIP: release using goreleaser

[hilary]

TODO:

• test the artifacts (there's a set in my github account)
• revert commit with test settings

[bentranter]

So far so good! I spent some time trying this against my own fork, and have a few pieces of feedback:

• If make release fails during the scripts/release.sh step for some reason (ie, not being able to connect to Docker, repo is in a dirty state, access to Dockerhub is denied, etc), simply retrying the make release task could cause unexpected behaviour for the user invoking it. This is because the version is already bumped, and a tag on the repo is already created, so when make release is invoked again, a new version and tag is created, instead of re-trying scripts/release.sh on the existing version and tag. Maybe there's a way to detect this and retry scripts/releash.sh if that fails? Maybe checking if the branch name matches tags/x.x.x?
• Related to the steps above, there might be a few more things we want to mention so that users can avoid failures related to goreleaser. In prerequisites, we should consider mentioning,
  • That you need Docker running on the machine you want to release from,
  • That you need to be logged in (via docker login, for example),
  • That your repo must not be in a dirty state (because goreleaser doesn't like that).

Keep in mind that my comments above assume that a human will use this script – if the intention is for this to only ever be done on CI, then my feedback may not apply.

[hilary]

For now, humans will run make release, which means we need the robustness. We'll get to travis running it, just not in one step.

I have multiple steps under the hood, I just need to rejigger / expose those steps, as well as annotate what to do if the process dies in an interim state.

[hilary]

Oh, and it isn't goreleaser that objects to your repo being in a dirty state. That's a check I put in in scripts/version.sh. We'll get stricter down the road. 😄

[bentranter]

@hilary I think goreleaser performs that check as well. I've got a TODO.md in my local copy of the repo that I don't check in, and if I run goreleaser from the root of the repo, I get the following output:

   • releasing using goreleaser 0.113.0...
   • could not find a config file, using defaults...
   • RUNNING BEFORE HOOKS
   • LOADING ENVIRONMENT VARIABLES
   • GETTING AND VALIDATING GIT STATE
      • releasing v1.23.1, commit 749efc752f74e2c7f94253ce8255e7be8acb279e
   ⨯ release failed after 0.08s error=git is currently in a dirty state, please check in your pipeline what can be changing the following files:
?? TODO.md

[hilary]

Ah, right. I check for staged but uncommitted changes, iirc.

[hilary]

Ok, I've hardened quite a bit.

Re: dirty state. Releasing now defaults to BRANCH=master and checks out the branch at the start of the process.
Most of the rest should be clear from CONTRIBUTING.

[bentranter]

Post in #in_support to request access.

We might want to add a note that this is for DO employees only, just to avoid confusion for any public contributors.

[hilary]

Moving branch to digitalocean account, opened #521