Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set ldflags in snap build #529

Merged
merged 2 commits into from
Jul 31, 2019
Merged

set ldflags in snap build #529

merged 2 commits into from
Jul 31, 2019

Conversation

hilary
Copy link
Contributor

@hilary hilary commented Jul 31, 2019

also updated how the version is set because version-script has been deprecated

bentranter
bentranter approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bentranter bentranter merged commit 49c8268 into digitalocean:master Jul 31, 2019
@hilary hilary deleted the update_snap branch August 1, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentranter bentranter bentranter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hilary @bentranter