Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load-balancers: add support for size_unit field #287

Merged
merged 1 commit into from
Oct 21, 2021
Merged

load-balancers: add support for size_unit field #287

merged 1 commit into from
Oct 21, 2021

Conversation

dikshant
Copy link
Contributor

This adds the new size_unit field. Users can now supply the size_unit as an integer > 1 instead of using lb_size

andrewsomething
andrewsomething requested changes Oct 20, 2021
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one suggestion in line about the changelog

andrewsomething
andrewsomething approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsomething andrewsomething merged commit d39c400 into digitalocean:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dikshant @andrewsomething