Check if list bridge output is empty #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlayher
suggested changes
Jun 2, 2018
ovs/vswitch.go
Outdated
| @@ -88,6 +88,9 @@ func (v *VSwitchService) ListBridges() ([]string, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| if string(output) == "" { | |||
| return []string{}, err | |||
There was a problem hiding this comment.
Let's return nil, nil in this case.
There was a problem hiding this comment.
@mdlayher
Is it good to use nil to instead []string{} ?
I think ListBridges() can return an empty array when someone tries to call it to get bridges length.
There was a problem hiding this comment.
Yep, so nil is fine because whenever someone is working with a slice, they are either iterating it or trying to access a specific element, which they should only do after making a bounds check.
For the purposes, nil and []string{} are effectively equivalent, but I prefer nil because it truly conveys "nothing" is returned.
Does that make sense?
There was a problem hiding this comment.
Get it. Let me fix for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
strings.Splitwill let VSwitch.ListBridges() result to []string{""} not []string{}if
ovs-vsctl list-broutput string is empty: "".