Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu: consider moving to github.com/digitalocean/go-qemu/qemu #133

Closed
mdlayher opened this issue Oct 19, 2016 · 1 comment · Fixed by #137
Closed

qemu: consider moving to github.com/digitalocean/go-qemu/qemu #133

mdlayher opened this issue Oct 19, 2016 · 1 comment · Fixed by #137
Labels
qemu

Comments

@mdlayher
Copy link
Contributor

For a long time, I didn't like the pattern I mentioned in the title.

Now, I find it pretty aggravating when repo and package names differ, because it's a surprise that you won't find out unless you explicitly check the code or docs.

Moving package qemu to a "subpackage" would also help clarify that this repository is a collection of packages for interacting with QEMU.

On the other hand, right now, it's front and center, and the first thing users see. That's arguably something we want to preserve as well.

Thoughts?
@mdlayher mdlayher added the qemu label Oct 19, 2016
@danderson
Copy link
Collaborator

+1 from me. Having package names that don't match the import path ends up being a landmine that trips up a bunch of people. For the visibility question, READMEs in various directories can still be slanted one way or another to steer people to the most relevant thing.

@mdlayher mdlayher mentioned this issue Nov 18, 2016
Merged
suryatmodulus pushed a commit to suryatmodulus/go-qemu that referenced this issue Oct 1, 2022
@connorkuehl
upgrade go-libvirt to latest revision (@8648fbd) (digitalocean#180)
85651f1 
This involves some additional changes to overcome breaking changes from
go-libvirt.

These are the new changes in this revision of go-libvirt since the last
release go-qemu has been using:

* remove invitation to empty IRC channel
* rpc_test: use Libvirt.addStream to add streams
* MockLibvirt: deep-copy response before adding ID
* monitor socket conn state in initLibvirtComms
* libvirttest: use atomic to read "serial"
* integration: wait for Disconnected before assert
* add CODEOWNERS
* Merge pull request digitalocean#152 from clarkwalcott/readme_update_rpc_link
* Docs: Update README with working link
* expose Libvirt.Disconnected method
* Add NetworkUpdateCompat
* update libvirt configuration step for new releases
* search generated include directory for header files
* ci updates (digitalocean#142)
* integration tests (digitalocean#141)
* take dialer as input instead of already existing connection (digitalocean#140)
* support authentication via polkit (digitalocean#138)
* fix some stream problems (digitalocean#137)
* Merge pull request digitalocean#136 from digitalocean/jenni/fix_potential_segfault
* write lock only needed for actual write
* rm unneeded nil'ing of reader and writer
* socket Disconnect close can race with nil of conn
* Merge pull request digitalocean#135 from digitalocean/jenni/update_cgo
* run go get golang.org/x/tools/go/internal/cgo@v0.1.1
* Merge pull request digitalocean#134 from digitalocean/jenni/add_socket_type
* change socket to pointer ref
* Merge branch 'master' of github.com:digitalocean/go-libvirt into jenni/add_socket_type
* Merge pull request digitalocean#133 from digitalocean/jenni/fix_event_unsubscribe_race
* reorder stream shutdown/delete
* fix race in disconnect of event stream cleanup
* add socket type to handle socket connection management
* Merge pull request digitalocean#132 from digitalocean/jenni/fix_client_deadlock
* fix typo and func conciseness
* move listen and cleanup into a func
* add timeout on waiting for disconnected
* move temporary read error check to a function
* Libvirt chan socketCleanupDone -> disconnected
* fix accidental go fmt of generated files
* add connect/disconnect to unit tests
* add tests for callback cleanup on connection disconnect
* fix rpc lookup test
* fix deadlocked clients on lack of libvirt response
* add more robust connection error checking
* Merge pull request digitalocean#131 from digitalocean/jenni/fix_invalid_test_data
* fix incorrect test data
* Merge pull request digitalocean#130 from digitalocean/jenni/stream_shutdown
* fix missing stream shutdown in lifecycle subscribe
* Merge pull request digitalocean#129 from digitalocean/geoff/vet-cleanup
* remove travis config file
* Clean up some linter errors
* Merge pull request digitalocean#125 from dmacvicar/dmacvicar_puberror
* Run generators against libvirt 7.2.0
* Unexport From* (ErrorDomain)
* golint
* go fmt
* libvirt.Error: expose only Code and Message
* Run generators against libvirt 7.1.0
* go fmt
* Make libvirtError public (libvirt.Error)
* github actions (digitalocean#128)
* internal/event/stream: fixes unsafe queue access (digitalocean#127)
* Merge pull request digitalocean#124 from sam-github/check-wrapped-errors
* Check wrapped errors for IsNotFound()
* Fix two race conditions related to Disconnect (digitalocean#120)
* Merge pull request digitalocean#119 from weizhouapache/readme-add-tls-port
* README: Add missing tls port in example
* README: Add example connect to libvirt via TLS over TCP (digitalocean#118)
* Add overload for Connect() to allow other libvirt drivers (digitalocean#117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
qemu
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

qemu: move to go-qemu/qemu, update documentation digitalocean/go-qemu
2 participants
@danderson @mdlayher