Skip to content

Commit

Permalink
APPS-8711: container termination controls (#873)
Browse files Browse the repository at this point in the history
* APPS-8711: container termination controls

* remove specification/resources/apps/apps_get_database_connection_details.yml
  • Loading branch information
jcodybaker authored May 6, 2024
1 parent 20b5ea6 commit d8d3901
Show file tree
Hide file tree
Showing 7 changed files with 51 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ properties:
minimum: 1
maximum: 100
default: 80
example: 75
example: 75
3 changes: 2 additions & 1 deletion specification/resources/apps/models/app_job_spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ allOf:
- FAILED_DEPLOY: Indicates a job that runs after a component fails to deploy.
default: UNSPECIFIED
example: PRE_DEPLOY

termination:
$ref: app_job_spec_termination.yml
required:
- name
10 changes: 10 additions & 0 deletions specification/resources/apps/models/app_job_spec_termination.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
type: object
properties:
grace_period_seconds:
type: integer
format: int32
description: The number of seconds to wait between sending a TERM signal to a container and issuing
a KILL which causes immediate shutdown. (Default 120)
example: 120
maximum: 600
minimum: 1
3 changes: 3 additions & 0 deletions specification/resources/apps/models/app_service_spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,8 @@ allOf:
items:
$ref: app_route_spec.yml

termination:
$ref: app_service_spec_termination.yml

required:
- name
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
type: object
properties:
drain_seconds:
type: integer
format: int32
description: The number of seconds to wait between selecting a container instance
for termination and issuing the TERM signal. Selecting a container instance for
termination begins an asynchronous drain of new requests on upstream load-balancers. (Default 15)
example: 15
maximum: 110
minimum: 1

grace_period_seconds:
type: integer
format: int32
description: The number of seconds to wait between sending a TERM signal to a container and issuing
a KILL which causes immediate shutdown. (Default 120)
example: 120
maximum: 600
minimum: 1
6 changes: 5 additions & 1 deletion specification/resources/apps/models/app_worker_spec.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
allOf:
- $ref: app_component_base.yml
- $ref: app_component_instance_base.yml

- type: object
properties:
termination:
$ref: app_worker_spec_termination.yml
required:
- name

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
type: object
properties:
grace_period_seconds:
type: integer
format: int32
description: The number of seconds to wait between sending a TERM signal to a container and issuing
a KILL which causes immediate shutdown. (Default 120)
example: 120
maximum: 600
minimum: 1

0 comments on commit d8d3901

Please sign in to comment.