Skip to content

Commit

Permalink
deprecate app component routing/cors config (#833)
Browse files Browse the repository at this point in the history
users should use ingress rules instead

Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>
  • Loading branch information
Gregory Mankes and andrewsomething authored Oct 16, 2023
1 parent 10dc525 commit ff8c689
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 7 deletions.
9 changes: 7 additions & 2 deletions specification/resources/apps/models/app_functions_spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,17 @@

type: object
properties:

cors:
$ref: apps_cors_policy.yml
allOf:
- $ref: apps_cors_policy.yml
- description: (Deprecated - Use Ingress Rules instead).
- deprecated: true

routes:
type: array
description: A list of HTTP routes that should be routed to this component.
description: (Deprecated - Use Ingress Rules instead). A list of HTTP routes that should be routed to this component.
deprecated: true
items:
$ref: app_route_spec.yml

Expand Down
2 changes: 1 addition & 1 deletion specification/resources/apps/models/app_route_spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ title: A criterion for routing HTTP traffic to a component.
type: object
properties:
path:
description: An HTTP path prefix. Paths must start with / and must be unique across
description: (Deprecated - Use Ingress Rules instead). An HTTP path prefix. Paths must start with / and must be unique across
all components within an app.
type: string
example: /api
Expand Down
8 changes: 6 additions & 2 deletions specification/resources/apps/models/app_service_spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ allOf:
- type: object
properties:
cors:
$ref: apps_cors_policy.yml
allOf:
- $ref: apps_cors_policy.yml
- description: (Deprecated - Use Ingress Rules instead).
- deprecated: true

health_check:
$ref: app_service_spec_health_check.yml
Expand All @@ -32,7 +35,8 @@ allOf:

routes:
type: array
description: A list of HTTP routes that should be routed to this component.
description: (Deprecated - Use Ingress Rules instead). A list of HTTP routes that should be routed to this component.
deprecated: true
items:
$ref: app_route_spec.yml

Expand Down
8 changes: 6 additions & 2 deletions specification/resources/apps/models/app_static_site_spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,17 @@ allOf:
example: dist/

cors:
$ref: apps_cors_policy.yml
allOf:
- $ref: apps_cors_policy.yml
- description: (Deprecated - Use Ingress Rules instead).
- deprecated: true

routes:
type: array
items:
$ref: app_route_spec.yml
description: A list of HTTP routes that should be routed to this component.
description: (Deprecated - Use Ingress Rules instead). A list of HTTP routes that should be routed to this component.
deprecated: true

required:
- name

0 comments on commit ff8c689

Please sign in to comment.