Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APPS-8385 Add new instance size fields and new pricing slugs #871

Merged
merged 1 commit into from
May 7, 2024
Merged

APPS-8385 Add new instance size fields and new pricing slugs #871

merged 1 commit into from
May 7, 2024

Conversation

greeshmapill
Copy link
Contributor

@greeshmapill greeshmapill commented Apr 18, 2024 •
edited
Loading

These changes are to go in as part of Apps relaunch and new pricing rollout in May.

  • Uses new instance size slugs in examples and for defaults.
  • Adds bandwidth_allowance_gib, deprecation_intent, scalable and single_instance_only to app instance size spec.

@greeshmapill greeshmapill marked this pull request as draft April 18, 2024 15:12
@greeshmapill
Copy link
Contributor Author

greeshmapill commented Apr 18, 2024 •
edited
Loading

The PR will be merged post the rollout in mid May.

@greeshmapill greeshmapill force-pushed the APPS-8385/new-pricing-updates branch 2 times, most recently from b9dd276 to 2ea99bb Compare May 6, 2024 11:04
@greeshmapill greeshmapill changed the title APPS-8385 Add/remove instance size fields as per new pricing changes APPS-8385 Add new instance size fields and new pricing slugs May 6, 2024
greeshmapill
greeshmapill commented May 6, 2024
View reviewed changes
specification/resources/apps/responses/examples.yml
instance_count: 1
http_port: 8080
routes:
- path: "/"
region: ams
app_cost: 5
app_tier_upgrade_cost: 17
Copy link
Contributor Author

@greeshmapill greeshmapill May 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing app_tier_upgrade_cost from the example, as it is marked for deprecation.

@greeshmapill greeshmapill marked this pull request as ready for review May 6, 2024 11:33
@greeshmapill
Copy link
Contributor Author

greeshmapill commented May 6, 2024 •
edited
Loading

The rollout of new pricing slugs is planned for May 7th.

@greeshmapill greeshmapill force-pushed the APPS-8385/new-pricing-updates branch from 2ea99bb to 9a0f075 Compare May 7, 2024 10:22
@greeshmapill
Copy link
Contributor Author

greeshmapill commented May 7, 2024 •
edited
Loading

The new pricing changes have been released. This PR can be merged.

danaelhe
danaelhe approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danaelhe danaelhe merged commit f331844 into digitalocean:main May 7, 2024
6 checks passed
@digitalocean-engineering digitalocean-engineering mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spinits4 spinits4 spinits4 approved these changes

@danaelhe danaelhe danaelhe approved these changes

@ssaengs ssaengs ssaengs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greeshmapill @spinits4 @danaelhe @ssaengs