Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBaaS: Add API endpoint for applying cluster patches #909

Conversation

vsharma6855
Copy link
Contributor

No description provided.

@vsharma6855 vsharma6855 changed the title DBaS | Add API endpoint for applying cluster patches DBaaS | Add API endpoint for applying cluster patches Sep 9, 2024
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I did have a suggestion in-line re: operationId

@@ -0,0 +1,47 @@
operationId: databases_update_installUpdate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operation ID is used by client generation tools to produce the method name. For example pydo, our Python client, will end up having a method with the redundant name databases.update_install_update. This might be more natural:

Suggested change
operationId: databases_update_installUpdate
operationId: databases_install_update

Our linter enforces using consistent operation IDs across our API. As this would be the first PUT using install, you'll also need to add it here so that it passes:

const PUT = ["update", "promote"];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed an additional commit to allow this to pass the linter check: e41ef07

vsharma6855 and others added 3 commits September 17, 2024 17:07
…te.yml

Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>
…te.yml

Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>

parameters:
- $ref: 'parameters.yml#/database_cluster_uuid'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a single line in between should be enough.

@loosla
Copy link
Contributor

loosla commented Sep 17, 2024

Looks good to me

Copy link

gitguardian bot commented Sep 17, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13808615 Triggered Basic Auth String 11eb0dc specification/resources/databases/models/opensearch_connection.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@andrewsomething andrewsomething merged commit 21e0351 into digitalocean:main Sep 17, 2024
6 of 7 checks passed
@andrewsomething andrewsomething changed the title DBaaS | Add API endpoint for applying cluster patches DBaaS: Add API endpoint for applying cluster patches Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants