Skip to content

Commit

Permalink
Remove "continue-on-error" (#129)
Browse files Browse the repository at this point in the history
remove "continue-on-error" on `create-pr` step in pipeline to have a clear failure if unsuccessful
  • Loading branch information
danaelhe authored Nov 15, 2022
1 parent 72b96c1 commit 0463243
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/python-client-gen.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ jobs:
- name: Create Pull Request
id: create-pr
if: steps.add-commit-changes.outcome == 'success'
continue-on-error: true
run: gh pr create --title "[bot] Re-Generate w/ digitalocean/openapi ${{ github.event.inputs.openapi_short_sha }}" --body "Regenerate python client with the commit, [${{ github.event.inputs.openapi_short_sha }}](https://github.com/digitalocean/openapi/commit/${{ github.event.inputs.openapi_short_sha }}) , pushed to digitalocean/openapi. Owners must review to confirm if integration/mocked tests need to be added to the client to reflect the changes." --head "${{ env.NEW_BRANCH }}" -r digitalocean/api-cli
env:
GH_TOKEN: ${{ secrets.WORKFLOW_TOKEN }}

0 comments on commit 0463243

Please sign in to comment.