Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mocked Tests: Image Actions #331

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

loosla
Copy link
Contributor

@loosla loosla commented Sep 9, 2024

This PR is adding mocked tests for image_actions.get, image_actions.list, image_actions.post

Related to #211

@andrewsomething
Copy link
Member

We may want to fix Makefile: PYLINT_ARGS is empty for make lint-tests.
Not sure what the intention is: should we remove PYLINT_ARGS or assign the same value as in github actions - https://github.com/digitalocean/pydo/blob/main/.github/workflows/pr.yaml#L40

We set PYLINT_ARGS="--disable=fixme" in the GitHub workflow so that TODO comments do not blocker pull requests as we have a number of them in the code base. When run locally, it may be useful to quickly find where we have TODO comments that still need to be addressed. We pass the empty PYLINT_ARGS in the Makefile so that it is passed through in the environment. If you want to disable the warnings locally, you can run:

PYLINT_ARGS="--disable=fixme" make lint-tests

@andrewsomething andrewsomething self-requested a review September 10, 2024 20:46
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@loosla loosla merged commit 7b01498 into main Sep 10, 2024
5 checks passed
@loosla loosla deleted the alushnikova/add-mocked-image-actions-tests branch September 10, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants