Added monitoring boolean #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonnydford I would suggest moving over the code Josh wrote on hashicorp/terraform#13494. Also, I would read the comments on that PR to handle some of the concerns not addressed yet. |
radeksimko
approved these changes
Sep 14, 2017
There was a problem hiding this comment.
Hi @jonnydford
thanks for the contribution here.
I made a tiny change to the test function - it originally had lowercase first letter which was causing it to not run automatically under go test - I just made that single letter uppercase and pushed to your branch.
I hope you don't mind.
This PR otherwise LGTM 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added for enhancement: https://github.com/terraform-providers/terraform-provider-digitalocean/issues/12