Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom_image: Surface a better error to users if image import fails. #613

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

andrewsomething
Copy link
Member

When we initiate an import of a custom image, we poll until it becomes available. If there is a problem with the image its status moves to deleted and an error_message is populated. We do not currently surface that error message to users. It's only visible in the debug logging for the API requests.

After this PR, error message should be more helpful. E.g.

Error: Error waiting for image (81502973) to become ready: We had a problem decompressing your file. This typically happens if the archive is corrupt or contains multiple files. Please try decompressing the file locally and uploading the uncompressed image, or recompressing using gzip or bzip2.

@danaelhe danaelhe self-requested a review April 2, 2021 15:07
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewsomething andrewsomething merged commit 1cfb861 into main Apr 2, 2021
@andrewsomething andrewsomething deleted the asb/surface-image-error branch April 2, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants