Implement user storage consent #1644
Conversation
Co-authored-by: Pram Gurusinga <pratama.gurusinga@digitalservice.bund.de> Co-authored-by: Florian Drews <florian.drews@digitalservice.bund.de>
… the formular.server.ts
| AWS_S3_REGION: string; | ||
| AWS_S3_ENDPOINT: string; | ||
| AWS_S3_DATA_CONSENT_FGR_ACCESS_KEY: string; | ||
| AWS_S3_DATA_CONSENT_FGR_SECRET_KEY: string; | ||
| AWS_S3_DATA_CONSENT_FGR_BUCKET_NAME: string; |
There was a problem hiding this comment.
maybe we should drop the AWS_ prefix here (and everywhere throughout)? 😅
There was a problem hiding this comment.
I think I understand why Alex did this, based on my experience with the aws cli. This is how AWS typically shows examples for environment variables. The CLI tools also accept environment variables in this format.
reference: https://docs.aws.amazon.com/cli/v1/userguide/cli-configure-envvars.html
|
|
||
| let instance: S3Client | undefined = undefined; | ||
|
|
||
| export const createClientDataConsentFgr = () => { |
There was a problem hiding this comment.
I would (strongly) vote for having a shared storage service, that we can then scope by app service (consent, file-upload, ...).
So this would be a generic s3 instance
There was a problem hiding this comment.
to be discussed in the Dev Exchange next week!
| .replaceAll(".", "-"); | ||
| }; | ||
|
|
||
| export const storeConsentFgrToS3Bucket = async (request: Request) => { |
There was a problem hiding this comment.
if we use a shared storage service, this could be moved into its own consent service and act as the main interface to the application
There was a problem hiding this comment.
also, I think this function only needs the request.headers, not the whole object? (just to simplify the interface)
There was a problem hiding this comment.
for the first comment, this is file is related store something in the S3 bucket. As we already discussed, we renamed the folder to be externalDataStorage.
For the second comment, I can change, but in case a new flow action is added and needs another data from the request (body, formData, referrer or etc), all the functions must be changed again.
| region_name="eu-central-1" | ||
| ) | ||
|
|
||
| s3_client.create_bucket(Bucket="a2j-rechtsantragstelle-data-consent-fgr", CreateBucketConfiguration={ |
There was a problem hiding this comment.
does the hardcoded name here matter?
There was a problem hiding this comment.
yeap, if I change the name, I need to change the name for the local development .env as well
There was a problem hiding this comment.
and btw, this file is executed on the docker container and not in your local development or app
| const asyncFlowActions = { | ||
| "/grundvoraussetzungen/datenverarbeitung": storeConsentFgrToS3Bucket, | ||
| }; |
There was a problem hiding this comment.
one alternative I just thought of: adding it in the flow config, specifically under meta of that step. not sure whether that is more or less confusing 😅
There was a problem hiding this comment.
I would prefer to have here for now, but we can move to the steps config from this PR once it's implemented 😃
Co-authored-by: Pram Gurusinga <pratama.gurusinga@digitalservice.bund.de> Co-authored-by: judithmh <40442827+judithmh@users.noreply.github.com>
|
No description provided.