feat(sidebar navigation): update sidebar navigation styling #1649
Conversation
|
@ingriddorioschulze can you check the possibility to add some unit tests? I'm aware the tests don't exist at the moment, but it would be cool to start to have some unit tests for non existing components 😃 |
|
There was a problem hiding this comment.
Thanks for split the tests, they are much better now 😎
I would like to see every test verifying behavior independently of the child component. This way, we can decouple the tests, ensuring that changes to the child component don’t cause the parent component tests to break.
| const nav = screen.getByRole("navigation"); | ||
| expect(nav).toHaveClass("bg-white border-[1px] border-blue-400"); | ||
|
|
||
| const list = screen.getByRole("list"); |
There was a problem hiding this comment.
if I change the NavigationList to render a div without the role of list, this test will fail, but the error should be point in the NavigationList test and not in the FlowNavigation test.
My recommendation, we don't care here what the NavigationList renders, only care what's is called inside of the FlowNavigation. In the NavigationList.test.tsx, we should test what the NavigationList renders, so we test what the component does without expect what the child component does.
This PR contains the new sidebar navigation styling:
Before
After