Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RISDEV-4460 improve rendering of element structure #519

Merged

Conversation

malte-laukoetter
Copy link
Member

No description provided.

@malte-laukoetter malte-laukoetter force-pushed the RISDEV-4460-Improve-rendering-of-element-structure branch from 5b0ec77 to 654f934 Compare August 13, 2024 08:14
@malte-laukoetter malte-laukoetter merged commit 654f934 into main Aug 13, 2024
18 checks passed
@malte-laukoetter malte-laukoetter deleted the RISDEV-4460-Improve-rendering-of-element-structure branch August 13, 2024 08:19
@andreasphil
Copy link
Member

@malte-laukoetter Great work (as usual)!

I just noticed two things:

In our design the num is inline with the elements it belongs to:

Design

I didn't see that in the app:

App


And: There are some glitches where borders collapse and/or elements don't extend to the full width:

Bildschirmfoto 2024-08-14 um 09 32 05

I bet the markup can be quite tricky/complex but do you see a way to fix those? For reference I looked at this mod in Chrome.

@malte-laukoetter
Copy link
Member Author

Thanks for catching that, i actually added the special num handling but it was also butchered a bit with the transpiling problem (thats the reason for the non full width num). But it should all be fixed now ^^

@malte-laukoetter
Copy link
Member Author

malte-laukoetter commented Aug 14, 2024

Bug tickets for the transpiling problems: vuejs/core#11613 & evanw/esbuild#3877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants