Don't panic if autocfg probe fails #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: [autocfg panics when building with `-Zbuild-std`][1].
Instead of panicking when the `i128` feature is requested but
`probe_type("i128")` fails, just go ahead and enable the feature. If
`i128` truly isn't available then compilation will still fail, just
later on. This is unlikely to be an issue in practice since [`i128`
was stabilized in Rust 1.26.0][2].
Tested by building with:
cargo +nightly build --target=x86_64-unknown-uefi \
-Zbuild-std=core,alloc --no-default-features \
--features=i128
[1]: cuviper/autocfg#34
[2]: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1260-2018-05-10
|
thanks makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: autocfg panics when building with
-Zbuild-std.Instead of panicking when the
i128feature is requested butprobe_type("i128")fails, just go ahead and enable the feature. Ifi128truly isn't available then compilation will still fail, justlater on. This is unlikely to be an issue in practice since
i128was stabilized in Rust 1.26.0.
Tested by building with:
I imagine that since the readme lists compatibility starting with rustc 1.31, the
i128feature could probably be dropped entirely, but I figure this more minimal change is easier.