Update Phone Codes for Vodafone and Kyivstar Operators #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitoksmile
reviewed
Mar 14, 2024
| @@ -76,7 +76,7 @@ data class InputGroupMoleculeData(val items: List<TextInputMoleculeData>) : Inpu | |||
| @Composable | |||
| @Preview | |||
| fun InputGroupMoleculePreview() { | |||
| val PHONE_NUMBER_VALIDATION_PATTERN = "^38(039|050|063|066|067|068|073|091|092|093|094|095|096|097|098|099)\\d{7}\$" | |||
| val PHONE_NUMBER_VALIDATION_PATTERN = "^38(039|050|063|066|067|068|073|075|077|091|092|093|094|095|096|097|098|099)\\d{7}\$" | |||
There was a problem hiding this comment.
isn't it better to use only 1 source of truth instead of keeping this pattern in 6 places? PhoneNumberExt.PHONE_NUMBER_VALIDATION_PATTERN
There was a problem hiding this comment.
I'll review this later and find out the solution to handle this.
At first, I decided not to introduce such a significant changes to the code.
But not, I see that more work is needed and this is the better way to handle this.
|
Converted to draft, more work should be done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the Diia phone codes Regex patterns. Specifically, it includes the addition of new phone codes for the Vodafone and Kyivstar operators, ensuring our app remains up-to-date with the latest telecommunications infrastructure changes in Ukraine. The update includes modifications to existing Regex patterns where necessary and the addition of new codes to support the expanded service areas of these operators.
Changes made:
The addition and modification of these phone codes are crucial for maintaining the app's relevance and usefulness to our users, especially those subscribing to Vodafone and Kyivstar services. It ensures the Diia app accurately recognizes and handles phone numbers from these operators, enhancing user experience and trust in our app's capabilities.