fixes peer dependency issue and updates README #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @patricklafrance , I thought the order does not matter since it's on branch "support-cra5". You've merged !332 and I saw that everything seems to be working except that you can't install CRACO when you have CRA@5 installed. Can you also mention what things are not working at this moment? |
|
Oh sorry I haven’t notice your PR is for the support branch. |
|
No problems bro, I guessed you might not see that. Anyways It seems like everything is working now. That would be great if you can also publish an alpha version so we use it in real projects and fixing the issues as we encounter them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting Craco for CRA-5. This will fix the issue of "peer react-scripts@"^4.0.0" from @craco/craco@6.4.3".