Use jsesc instead of JSON.stringify to avoid JSON/HTML issues #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained here: https://mathiasbynens.be/notes/etago One can run into issues when trying to embed JSON containing HTML with <script> elements inside a <script> tag. Switching to a utility with support for this fixes the issue: https://github.com/mathiasbynens/jsesc#isscriptcontext
|
This is perfect 👍 Thank you so much for investigating and providing a fix! |
|
I added a test case to verify the fix and changed it so |
|
This is now live with NPM package version 2.1.8 🎉 https://github.com/dillonkearns/elm-pages/blob/master/CHANGELOG-NPM.md#218---2021-08-25 Thanks again for the PR! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue: #206
As explained here: https://mathiasbynens.be/notes/etago
One can run into issues when trying to embed JSON containing HTML with <script> elements inside a <script> tag.
Switching to a utility with support for this fixes the issue: https://github.com/mathiasbynens/jsesc#isscriptcontext
I am not a JS expert by any means, no hard feelings if a better solution is found, this is the best I could do.
Hope it helps 👍 ,
Daniel