Use writeFile instead of copyFile #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for elm-pages-todos pending review.Visit the deploys page to approve it
|
|
@dillonkearns Would be great to get something like this in to unblock Nix users! |
|
For other Nix users, this is patched in unstable and should work if you install elm-pages from there: https://github.com/NixOS/nixpkgs/pull/259186/files#diff-1f62c3e9682f06b9262172752136ec5c45f6c115253caf1350460b6e71f8b79cR1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305 for v3.0
This PR should prevent copy file from a potential read only node_modules folder to the working copy. Effectively by reading files from __dirname and creating new ones in the working copy.
I haven't fully tested since we still use 2.x in our frozen node_modules setup, but from a code review I think these are the only change needed.