Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing path in the files list in package.json #72

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Add missing path in the files list in package.json #72

merged 1 commit into from
Feb 18, 2020

Conversation

icidasset
Copy link
Contributor

@icidasset icidasset commented Feb 13, 2020 •
edited
Loading

I think this'll fix #71

@dillonkearns dillonkearns merged commit aea6fde into dillonkearns:master Feb 18, 2020
@dillonkearns
Copy link
Owner

Good catch, thank you so much @icidasset! 🙏

@dillonkearns
Copy link
Owner

dillonkearns commented Feb 18, 2020 •
edited
Loading

I think what I do in my CI build for elm-graphql might actually prevent this from happening...

https://github.com/dillonkearns/elm-graphql/blob/aa0bf995a7e46e8401e2f9185928d680dda03efc/bin/approve#L10-L11

It's a bit of a silly hack, but it's really nice to have the CI catch it if there's an issue like this.

@icidasset icidasset deleted the patch-1 branch February 25, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elm-pages develop throws error in v1.2.8
2 participants
@icidasset @dillonkearns