Fix Windows path separator bug #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-maas
reviewed
Mar 15, 2020
|
@all-contributors please add @vViktorPL for code. |
|
I've put up a pull request to add @vViktorPL! 🎉 |
This was referenced Mar 17, 2020
|
@all-contributors please add @y0hy0h for userTesting. |
|
I've put up a pull request to add @y0hy0h! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #81 bug. The problem was that OS path separator was used to split file paths, however as paths are listed through
globlib which is platform agnostic in terms of the output scan paths and always separates file paths with/: see details here.