Fix bug when missing workbook relationship #277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug when missing workbook relationship
Add a check to see if the list is empty before trying to access it's
contents. If an excel file has an overridden relationship with no word
"book" in the name it will attempt to grab the first item of an empty
list when looking up workbook relationships.
There could be a better fix to this issue I'm not well enough versed in
the xslx specification. The following xlsx file caused the issue.
In
[Content_types].xml
it is overriding the relationships to point at_rels/.rels
rather thanxl/_rels/workbook.xml.rels
. This causes theworkbook_relationships
list to be empty causes the error mentionedabove. One can see that it does indeed have a workbook relationship,
however it is being overridden.
[Contenet_types].xml
:xl/_rels/workbook.xml.rels
: