Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ipv6 cidr blocks from all the security groups in network module #6455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AmitPhulera
Copy link
Contributor

Removing the cidr blocks for ipv6 entries as part of cleanup of the network module.

Ran cchq staging terraform plan, got

 # module.network.aws_security_group.alb-sg will be updated in-place
  ~ resource "aws_security_group" "alb-sg" {
        id                     = "sg-0e7192eb2cb7907e5"
      ~ ingress                = [
          - {
              - cidr_blocks      = [
                  - "0.0.0.0/0",
                ]
              - description      = ""
              - from_port        = 443
              - ipv6_cidr_blocks = [
                  - "::/0",
                ]
              - prefix_list_ids  = []
              - protocol         = "tcp"
              - security_groups  = []
              - self             = false
              - to_port          = 443
            },
          - {
              - cidr_blocks      = [
                  - "0.0.0.0/0",
                ]
              - description      = ""
              - from_port        = 80
              - ipv6_cidr_blocks = [
                  - "::/0",
                ]
              - prefix_list_ids  = []
              - protocol         = "tcp"
              - security_groups  = []
              - self             = false
              - to_port          = 80
            },
          - {
              - cidr_blocks      = [
                  - "10.201.0.0/16",
                ]
              - description      = ""
              - from_port        = 0
              - ipv6_cidr_blocks = []
              - prefix_list_ids  = []
              - protocol         = "-1"
              - security_groups  = []
              - self             = false
              - to_port          = 0
            },
          + {
              + cidr_blocks      = [
                  + "0.0.0.0/0",
                ]
              + description      = ""
              + from_port        = 443
              + ipv6_cidr_blocks = []
              + prefix_list_ids  = []
              + protocol         = "tcp"
              + security_groups  = []
              + self             = false
              + to_port          = 443
            },
          + {
              + cidr_blocks      = [
                  + "0.0.0.0/0",
                ]
              + description      = ""
              + from_port        = 80
              + ipv6_cidr_blocks = []
              + prefix_list_ids  = []
              + protocol         = "tcp"
              + security_groups  = []
              + self             = false
              + to_port          = 80
            },
          + {
              + cidr_blocks      = [
                  + "10.201.0.0/16",
                ]
              + from_port        = 0
              + ipv6_cidr_blocks = []
              + prefix_list_ids  = []
              + protocol         = "-1"
              + security_groups  = []
              + self             = false
              + to_port          = 0
            },
        ]
        name                   = "alb-sg-staging"
        tags                   = {
            "Name" = "alb-sg-staging"
        }
        # (7 unchanged attributes hidden)

      - timeouts {}
    }

  # module.network.aws_security_group.elasticache will be updated in-place
  ~ resource "aws_security_group" "elasticache" {
        id                     = "sg-05981a4acb5d5d0fd"
      ~ ingress                = [
          - {
              - cidr_blocks      = [
                  - "10.201.10.0/24",
                  - "10.201.11.0/24",
                  - "10.201.12.0/24",
                  - "10.201.20.0/24",
                  - "10.201.21.0/24",
                  - "10.201.22.0/24",
                ]
              - description      = ""
              - from_port        = 6379
              - ipv6_cidr_blocks = [
                  - "::/0",
                ]
              - prefix_list_ids  = []
              - protocol         = "tcp"
              - security_groups  = []
              - self             = false
              - to_port          = 6379
            },
          + {
              + cidr_blocks      = [
                  + "10.201.10.0/24",
                  + "10.201.11.0/24",
                  + "10.201.12.0/24",
                  + "10.201.20.0/24",
                  + "10.201.21.0/24",
                  + "10.201.22.0/24",
                ]
              + description      = ""
              + from_port        = 6379
              + ipv6_cidr_blocks = []
              + prefix_list_ids  = []
              + protocol         = "tcp"
              + security_groups  = []
              + self             = false
              + to_port          = 6379
            },
        ]
        name                   = "elasticache-staging"
        tags                   = {
            "Name" = "elasticache-staging"
        }
        # (7 unchanged attributes hidden)

      - timeouts {}
    }

  # module.network.aws_security_group.rds will be updated in-place
  ~ resource "aws_security_group" "rds" {
        id                     = "sg-0b811c0b4425b9ab7"
      ~ ingress                = [
          - {
              - cidr_blocks      = [
                  - "10.201.10.0/24",
                  - "10.201.11.0/24",
                  - "10.201.12.0/24",
                  - "10.201.40.0/24",
                  - "10.201.41.0/24",
                  - "10.201.42.0/24",
                ]
              - description      = ""
              - from_port        = 5432
              - ipv6_cidr_blocks = [
                  - "::/0",
                ]
              - prefix_list_ids  = []
              - protocol         = "tcp"
              - security_groups  = []
              - self             = false
              - to_port          = 5432
            },
          + {
              + cidr_blocks      = [
                  + "10.201.10.0/24",
                  + "10.201.11.0/24",
                  + "10.201.12.0/24",
                  + "10.201.40.0/24",
                  + "10.201.41.0/24",
                  + "10.201.42.0/24",
                ]
              + description      = ""
              + from_port        = 5432
              + ipv6_cidr_blocks = []
              + prefix_list_ids  = []
              + protocol         = "tcp"
              + security_groups  = []
              + self             = false
              + to_port          = 5432
            },
        ]
        name                   = "rds-staging"
        tags                   = {
            "Name" = "rds-staging"
        }
        # (7 unchanged attributes hidden)

      - timeouts {}
    }

Will apply the changes by cchq terraform apply -target=module.network.aws_security_group.rds -target=module.network.aws_security_group.elasticache -target=module.network.aws_security_group.alb-sg

Environments Affected

Staging, India, Prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants