Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network manager funnel performance #391

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Network manager funnel performance #391

wants to merge 15 commits into from

Conversation

hemant10yadav
Copy link
Contributor

@hemant10yadav hemant10yadav commented Sep 16, 2024 •
edited
Loading

@hemant10yadav hemant10yadav changed the title Hy/network manager funnel performance Network manager funnel performance Sep 16, 2024
Base automatically changed from hy/invite-program to hy/managed-opportunity-creation September 18, 2024 06:54
Base automatically changed from hy/managed-opportunity-creation to main September 18, 2024 06:54
@hemant10yadav hemant10yadav self-assigned this Sep 18, 2024
@hemant10yadav hemant10yadav marked this pull request as draft September 30, 2024 03:00
@hemant10yadav hemant10yadav marked this pull request as ready for review September 30, 2024 08:15
calellowitz
calellowitz reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good. a few questions and one small nit

commcare_connect/program/helpers.py Outdated Show resolved Hide resolved
commcare_connect/program/helpers.py Show resolved Hide resolved
commcare_connect/program/helpers.py Outdated Show resolved Hide resolved
@pxwxnvermx pxwxnvermx mentioned this pull request Oct 14, 2024
Open
pxwxnvermx
pxwxnvermx approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@pxwxnvermx pxwxnvermx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 🙌🏽

calellowitz
calellowitz approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including tests, looks like those still only cover some of the calculations, so adding tests for the remaining ones would be great but otherwise looks good, and not blocking on that. Would also be good to also have QA validate the calculations if they haven't yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sravfeyn sravfeyn sravfeyn left review comments

@pxwxnvermx pxwxnvermx pxwxnvermx approved these changes

@calellowitz calellowitz calellowitz approved these changes

Assignees

@hemant10yadav hemant10yadav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hemant10yadav @sravfeyn @calellowitz @pxwxnvermx