Remove -e from repo requirements #24540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpell
requested review from
dannyroberts,
proteusvacuum,
emord and
calellowitz
emord
reviewed
Jun 10, 2019
| @@ -4,7 +4,7 @@ jsonobject==0.9.9 | |||
| jsonobject-couchdbkit~=0.9 | |||
| # celery 4.1.1 forked to work around https://github.com/celery/celery/issues/4737 | |||
| # upgrade when https://github.com/celery/celery/issues/4980 is fixed | |||
| -e git+git://github.com/nickpell/celery@dc7253614fd8500af78b09d1ceb79c50f1baac8d#egg=celery | |||
| git+git://github.com/nickpell/celery@dc7253614fd8500af78b09d1ceb79c50f1baac8d#egg=celery | |||
There was a problem hiding this comment.
should this have a version that goes with it? egg=celery==4.1.1b1 or something like that?
There was a problem hiding this comment.
Should it? I know we hypothesized this earlier but it seems to be working fine without it.
There was a problem hiding this comment.
so long as the previous releases continue to work it seems fine. TBH I'm not super sure why I included that with architect
emord
approved these changes
Jun 10, 2019
calellowitz
approved these changes
Jun 10, 2019
|
@calellowitz pip-tools is already upgraded: #24514 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jazzband/pip-tools#355 is resolved by jazzband/pip-tools#807 so we don't need the
-eanymore.