Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pyOpenSSL to 22.0.0 #32044

Merged
merged 1 commit into from
Oct 28, 2022
Merged

upgrade pyOpenSSL to 22.0.0 #32044

merged 1 commit into from
Oct 28, 2022

Conversation

biyeun
Copy link
Member

@biyeun biyeun commented Aug 22, 2022

Technical Summary

This upgrades pyOpenSSL to 22.0.0. Yes, it's the x.0.0 of a major release, but it looks like it's been around since January with no issues / updates.

Will be timing QA of this upgrade along with QA of additional SSO support of another IdP.

Safety Assurance

Safety story

Will be QA'd

Automated test coverage

Yes, we do have some usage tests at least for cryptography's usage in our SSO tests.

QA Plan

Test both SAML and OIDC support.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@biyeun biyeun added awaiting QA QA in progress. Do not merge product/invisible Change has no end-user visible impact product/prod-india-all-users Change will only be deployed to Dimagi "SaaS" environments dependencies Pull requests that update a dependency file labels Aug 22, 2022
@biyeun biyeun requested a review from a team as a code owner August 22, 2022 12:11
@dannyroberts dannyroberts reopened this Aug 22, 2022
@biyeun biyeun added QA Passed and removed awaiting QA QA in progress. Do not merge labels Oct 28, 2022
@biyeun biyeun merged commit 71514db into master Oct 28, 2022
@biyeun biyeun deleted the bmb/pyopenssl-upgrade-22.0.0 branch October 28, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file product/invisible Change has no end-user visible impact product/prod-india-all-users Change will only be deployed to Dimagi "SaaS" environments QA Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants