Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cs/sc 2473 ga phone apk heartbeat ff #32528

Closed
wants to merge 5 commits into from

Conversation

Charl1996
Copy link
Contributor

Note: this PR might or might not change depending on the outcome of this discussion, as there are 7 domains on production which will need to be dealt with appropriately before merging this PR.

Product Description

This PR GA's the phone_apk_heartbeat feature flag to accounts on the Standard Plan and higher.

Technical Summary

Ticket
This PR removes the feature flag phone_apk_heartbeat and grants the new phone_apk_heartbeat permission to all domains on Standard Plan or higher.

Feature Flag

None

Safety Assurance

Safety story

Tested locally:

  • Ensured Community plan does not have permission set
  • Ensured Standard plan and higher does have permission set

Automated test coverage

There might come some tests.

QA Plan

Will be tested on staging.

Migrations

  • The migrations in this code can be safely applied first independently of the code

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

I'm not sure how these types of migrations are reverted.

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@Charl1996 Charl1996 added reindex/migration Reindex or migration will be required during or before deploy product/all-users-all-environments Change impacts all users on all environments labels Jan 24, 2023
@Charl1996 Charl1996 closed this Feb 1, 2023
@Charl1996 Charl1996 deleted the cs/SC-2473-GA-phone_apk_heartbeat-ff branch February 1, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments reindex/migration Reindex or migration will be required during or before deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant