Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Skip Editions for standard #32561

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Fix Skip Editions for standard #32561

merged 1 commit into from
Feb 1, 2023

Conversation

sravfeyn
Copy link
Member

@sravfeyn sravfeyn commented Feb 1, 2023

Product Description

This privilege was intended to be from Standard, so this is fix for the mistake I did in #32431 The PR was deployed only on staging, so I will run cchq_prbac_grandfather_privs command manually on staging. @snopoke

Technical Summary

Followup on #32431

Feature Flag

Safety Assurance

Automated test coverage

QA Plan

Migrations

  • The migrations in this code can be safely applied first independently of the code

Rollback instructions

This is an accounting PR, to revert the privilege must be removed explicitly.

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@dimagimon dimagimon added the reindex/migration Reindex or migration will be required during or before deploy label Feb 1, 2023
@@ -13,7 +13,7 @@ def _grandfather_form_link_workflow_privs(apps, schema_editor):
call_command(
'cchq_prbac_grandfather_privs',
FORM_LINK_WORKFLOW,
skip_edition='Paused,Community,Standard',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR was deployed only on staging, so I will run this command manually on staging.

@sravfeyn sravfeyn merged commit 2286485 into master Feb 1, 2023
@sravfeyn sravfeyn removed the reindex/migration Reindex or migration will be required during or before deploy label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants