Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Persistent Menu Navigation a Sidebar #35142

Draft
wants to merge 9 commits into
base: es/2sticky2furious
Choose a base branch
from

Conversation

AddisonDunn
Copy link
Contributor

Product Description

Jira: one and two.

This PR:

  • Turns the persistent menu navigation into a sidebar when on desktop, but remaining an overlay on mobile
  • To accomplish the bullet above, I needed to "lock" the main content container, so that scrolling happens on the content container instead of the entire page. This way the persistent menu and the other content can be separately scrollable.
  • Removes the data preview bar on mobile
  • Removes the gray background around forms on mobile

To see what I mean by "locked" and "separately scrollable", see this video:
https://github.com/user-attachments/assets/eed7edaf-1036-4fb0-a705-16e4f3847a57

Gray background removed on mobile:
Screenshot 2024-09-18 at 4 03 01 PM

Technical Summary

I made some key changes to margins and the underlying DOM layout of web apps that I am hoping will be more of a boon than a burden.

Safety Assurance

Safety story

  • Everything looks good with testing locally: main app selection screen, case list screen with case tiles and map, form screen
  • This will go through QA

QA Plan

Going to go through QA, ticket TBD

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@dimagimon dimagimon added Risk: High Change affects files that have been flagged as high risk. Risk: Medium Change affects files that have been flagged as medium risk. labels Sep 18, 2024
@dimagimon dimagimon removed the Risk: High Change affects files that have been flagged as high risk. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Risk: Medium Change affects files that have been flagged as medium risk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants