Added Enterprise Data Exports Report #35462
Open
+130
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjriley
added
the
product/admin
mjriley
force-pushed
the
mjr/data-exports-report
branch
from
9fd706e to
cc754ce
Compare
jingcheng16
reviewed
Dec 9, 2024
| return bundle | ||
|
|
||
| def get_primary_keys(self): | ||
| return ('domain', 'export_type', 'export_subtype', 'name') |
There was a problem hiding this comment.
I tested on staging, I can have two export in same domain, with same export_type, export_subtype and name. In this case, adding owner won't be helpful. Should we add some other attribute like export_id?
| class EnterpriseDataExportReport(EnterpriseReport): | ||
| title = gettext_lazy('Data Exports') | ||
|
|
||
| def __init__(self, account, couch_user): |
There was a problem hiding this comment.
Tada! Got you! Same issue as mine when you reviewed my PR lol.
| elif doc_type == CaseExportInstance.__name__: | ||
| return _('Case') | ||
| else: | ||
| return _('Unknown') |
There was a problem hiding this comment.
In what case it will be unknown?
| SUBTYPE_MAP = { | ||
| is_standard: gettext_lazy('Standard'), | ||
| is_daily_saved_export: gettext_lazy('Daily Saved Export'), | ||
| is_excel_integration: gettext_lazy('Excel Integration'), |
There was a problem hiding this comment.
Why we don't support PowerBi/tableau integration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Enterprise Dashboard:
API:
Generated Report:
Technical Summary
Associated ticket: https://dimagi.atlassian.net/browse/SAAS-16298
Feature Flag
No feature flag, as we're doing iterative releases for this
Safety Assurance
Safety story
Tested locally
Automated test coverage
No automated tests so far. The generation logic should eventually be moved into its own functionality. That is the functionality I'd like to write tests for, but I think that is pending the approval of the iterators PR, which sets the precedent for this.
QA Plan
TBD, but this should go through QA.
QA should verify that the following are listed on the report/API:
Nothing else should appear on the report, so its valid to test that something like PowerBI feeds do not appear here.
Rollback instructions
Labels & Review