-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entry to subevent log when filtering out recipient #35509
Open
MartinRiese
wants to merge
8
commits into
master
Choose a base branch
from
riese/log_filter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: corehq/messaging/scheduling/scheduling_partitioned/models.py
Did you find this useful? React with a 👍 or 👎 |
MartinRiese
requested review from
a team,
minhaminha and
Jtang-1
and removed request for
a team
December 11, 2024 16:49
Jtang-1
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
Jtang-1
approved these changes
Dec 11, 2024
Jtang-1
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
When alert recipients are filtered out it is hard to figure out why. Currently we have bug in production that we cannot reproduce otherwise. This will help determine what exactly is happening.
Technical Summary
https://dimagi.atlassian.net/browse/SUPPORT-22779
Feature Flag
None
Safety Assurance
Automated tests and tested on staging.
Safety story
Automated test coverage
Yes.
QA Plan
Rollback instructions
Labels & Review