[webpack] UCR config pages #35510
Open
[webpack] UCR config pages #35510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All descdendant templates now use webpack (or don't use js).
orangejenny
added
Open for review: do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This migrates all pages that inherit from
userreports_base.htmlIt's a mix of pages that were already using requirejs, which are pretty trivial to migrate, and pages that never got migrated to requirejs, which are also pretty simple. None of this code depends on core reports js, and there are no libraries added here that aren't already used in webpack.
Feature Flag
UCR
Safety Assurance
Safety story
UI-level changes to a flagged (although widely used) feature. I've tested locally and will do a bit of testing on staging,
marking "don't merge" until that's complete(done).Automated test coverage
no
QA Plan
not requesting QA
Rollback instructions
Labels & Review