Merge branch 'hexojs:master' into fix_url_for

lib/permalink.ts

@@ -50,7 +50,13 @@ class Permalink {
   }
 
   stringify(data) {
-    return this.rule.replace(rParam, (match, name) => data[name]);
+    return this.rule.replace(rParam, (match, name) => {
+      const descriptor = Object.getOwnPropertyDescriptor(data, name);
+      if (descriptor && typeof descriptor.get === 'function') {
+        throw new Error('Invalid permalink setting!');
+      }
+      return data[name];
+    });
   }
 }
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "hexo-util",
-  "version": "3.1.0",
+  "version": "3.2.0",
   "description": "Utilities for Hexo.",
   "main": "dist/index",
   "types": "./dist/index.d.ts",

test/permalink.spec.js

@@ -76,4 +76,20 @@ describe('Permalink', () => {
       title: 'test'
     }).should.eql('2014/01/31/test');
   });
+
+  it('stringify() - avoid infinite loops', () => {
+    const post = {
+      get path() {
+        return this.permalink;
+      },
+
+      get permalink() {
+        const permalink = new Permalink('/:permalink');
+        return permalink.stringify(post);
+      }
+    };
+
+    (() => post.path).should.throw('Invalid permalink setting!');
+    (() => post.permalink).should.throw('Invalid permalink setting!');
+  });
 });

tsconfig.json

@@ -6,15 +6,9 @@
     "outDir": "dist",
     "declaration": true,
     "esModuleInterop": true,
-    "types": [
-      "node"
-    ],
+    "types": ["node"],
     "lib": ["ES2020", "ES2019"]
   },
-  "include": [
-    "lib/index.ts"
-  ],
-  "exclude": [
-    "node_modules"
-  ]
-}
+  "include": ["lib/**.ts"],
+  "exclude": ["node_modules"]
+}