Add debug render mesh for capsule and cylinder collider shapes. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without changing the way that the debug mesh's transform is calculated (just from scale), it's not possible to accurately show a capsule's orientation in the debug view. So, just use a cuboid and scale it along the capsule's AABB to get a reasonably accurate approximation. I also did a minor tidy of the transform sync code.
There are no cylinder shapes in 2d.
nebkor
changed the title
nebkor
commented
Feb 28, 2022
| transform.translation.y = tra.y * scale; | ||
| transform.translation.z = tra.z * scale; | ||
| transform.rotation = Quat::from_xyzw(rot.x, rot.y, rot.z, rot.w); | ||
| transform.translation = tra * scale; |
There was a problem hiding this comment.
I realize this is slightly out of scope for this PR.
|
Representing capsules/cylinders are cubes looks very misleading. Instead, we should generate new meshes for each capsule/cylinder, based on their dimensions, and use a scale of 1. |
|
Thank you for this PR! Starting with #138, cylinders and capsules (as well as all the other possible shapes) are supported by the new debug-render. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without changing the way that the debug mesh's transform is calculated (just from scale), it's not
possible to accurately show a capsule's orientation in the debug view. So, just use a cuboid and
scale it along the capsule's AABB to get a reasonably accurate approximation.
I also did a minor tidy of the transform sync code.